search

rikbruil / Doctrine-Specification

Doctrine Specification pattern for building queries dynamically and with re-usable classes for composition.
MIT License
50 stars 7 forks source link

SpecificationRepository as trait #19

Closed alle closed 7 years ago

alle commented 7 years ago

I second @juliangut as in #17 to make the SpecificationRepository as a trait, in order to be used in other repositories.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 99.636% when pulling 43dc37fd5ec0a891c7855e1c34256491c3dfe123 on elt:repository_as_trait into 86bbc2a21496f61b2eb2c3d097a0d939eda833fd on rikbruil:master.

juliangut commented 7 years ago

An SpecificationAware interface would be nice

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 99.636% when pulling f61b79cfead5d552b5f382404b28581f01ad3256 on elt:repository_as_trait into 86bbc2a21496f61b2eb2c3d097a0d939eda833fd on rikbruil:master.

rikbruil commented 7 years ago

Thanks for the PR, I agree an interface and trait would be useful.

I will merge this and tag it a little bit later.

rikbruil commented 7 years ago

FYI: I renamed SpecificationAware to SpecificationAwareInterface in #20

I did this for consistency in naming, otherwise haven't touched the code.

alle commented 7 years ago

@rikbruil OK, I got that.

juliangut commented 7 years ago

Nice! :+1: