search

riker-rs / riker

Easily build efficient, highly concurrent and resilient applications. An Actor Framework for Rust.
https://riker.rs
MIT License
1.02k stars 69 forks source link

Remove mentions of persistance #118

Closed olanod closed 4 years ago

olanod commented 4 years ago

While reading the docs I saw persist_event mentioned but didn't find it anywhere which was confusing, then I saw other mentions of persistence that seem to be just dead code. Didn't find much info on why or when it was removed so this is also a question about what's the deal with persistence? Anyway I thing if the feature comes back we'll always have git to tell us what the code looked like in the meantime is just dead code.

leenozara commented 4 years ago

Hi @olanod Thanks for raising this question. Basically, persistence used to be part of Riker 1.0. After Riker 2.0 was released the changes were too significant to make persistence work in time. I didn't want to wait to release Riker 2.0 until persistence was in place. The code was simply commented out with the intention to get persistence working asap. This didn't happen since I was unable to commit time to the project for several months until recently.

We are making some changes to the projects organization with adding people to the team. We will discuss persistence and ask everyone if this is a feature that we should work on.

Thanks for your PR to remove the comments!