search

riker-rs / riker

Easily build efficient, highly concurrent and resilient applications. An Actor Framework for Rust.
https://riker.rs
MIT License
1.02k stars 69 forks source link

Fix recursive call of CreateError.to_string #123

Closed anacrolix closed 4 years ago

anacrolix commented 4 years ago

Fixes #120.

olexiyb commented 4 years ago

Hey, please fix lint issue.

igalic commented 4 years ago

to answer my own question, after looking at the full definition of the enum, the answer should be "yes"

anacrolix commented 4 years ago

Hey, please fix lint issue.

@olexiyb What lint issue? I don't see any CI.

igalic commented 4 years ago

see https://github.com/riker-rs/riker#pre-commit

leenozara commented 4 years ago

Hi @anacrolix your PR is almost there, you just need to run pre-commit run -a (you'll need pre-commit installed first) then push the commit to your PR.

olexiyb commented 4 years ago

Hey, please fix lint issue.

@olexiyb What lint issue? I don't see any CI.

Looks like link between travis and github is broken again https://travis-ci.org/github/riker-rs/riker/builds/703738615

anacrolix commented 4 years ago

Thanks, I can't get to this until next week.

leenozara commented 4 years ago

No worries, I'll get your branch and do it. Thanks for this fix!

anacrolix commented 4 years ago

Thanks!