search

riker-rs / riker

Easily build efficient, highly concurrent and resilient applications. An Actor Framework for Rust.
https://riker.rs
MIT License
1.02k stars 69 forks source link

fix(dashmap): use stable dashmap #141

Closed nothingismagick closed 3 years ago

nothingismagick commented 3 years ago

This is basically the same as pr #132, just resolved the conflict. I ran pre-commit, all tests pass, all examples seem to work fine and no warnings are thrown on build. I tested it integrated in a project that works with the current release version, and this change continues to work properly and as expected (on macOS). I did remove a couple of the changes proposed by @bfrog because there is apparently no longer any need for the Dashmap iterator and no reason to submit code that has warnings. ;)

I guess it would probably be good to add a test to check this deadlock issue though, but I am not sure how to replicate that.

Closes #131
Closes #122

image

nothingismagick commented 3 years ago

The reason that I think this change (once accepted) would warrant a new release is because of the new macOS silicon (which I have not been able to test, but am terribly worried about).

leenozara commented 3 years ago

@nothingismagick , @hardliner66 and team. Merging this now and will prepare a new release. Thanks!