rikhuijzer / PlutoStaticHTML.jl

Convert Pluto notebooks to HTML in automated workflows
https://PlutoStaticHTML.huijzer.xyz
MIT License
83 stars 7 forks source link

Rendering of UTF8 broken? Or maybe terminal color? #159

Open kellertuer opened 1 year ago

kellertuer commented 1 year ago

I added a small block to my notebooks to display package versions (since in the rendered variant I am hiding the loading block now), but it seems to show the UTF8 symbols wrong.

In there rendered PlutoStaticHTML I get

Screenshot 2023-01-07 at 11 27 25

which in Pluto looks much nicer

Screenshot 2023-01-07 at 11 31 37

not that the colours are so important, but at least the symbols correct would be nice – though the color commands might be what we see here?

Also PlutoStaticHTML seems to be stuck on 0.19.16 while 0.19.19 is out, Is such a strict compat necessary? You could set it to 0.19 (and not do updates for every patch of Pluto).

rikhuijzer commented 1 year ago

These are indeed terminal colors. According to https://github.com/rikhuijzer/PlutoStaticHTML.jl/pull/88/files, the with_terminal patch is applied if <script type="text/javascript" id="plutouiterminal"> is found in the body of the HTML. Maybe that goes wrong. I don't know where exactly it is not working for you so I cannot reproduce currently.

Also PlutoStaticHTML seems to be stuck on 0.19.16 while 0.19.19 is out, Is such a strict compat necessary? You could set it to 0.19 (and not do updates for every patch of Pluto).

If it wasn't necessary, I wouldn't have done it. PlutoStaticHTML depends on a lot of Pluto internals which may change at any moment.

kellertuer commented 1 year ago

The code will be put into all notebooks at some point, but the screenshot above is from

https://github.com/JuliaManifolds/Manopt.jl/blob/kellertuer/costgrad-and-cache/tutorials/Optimize!.jl#L76

once run with docs/make.jl from the same branch – the screenshot from Pluto is made from the same notebook run with Pluto 0.19.16

edit: Ah I can even link the output since deploying works for now again, its this result https://manoptjl.org/previews/PR174/tutorials/Optimize!/