search

rikhuijzer / PlutoStaticHTML.jl

Convert Pluto notebooks to HTML in automated workflows
https://PlutoStaticHTML.huijzer.xyz
MIT License
83 stars 7 forks source link

Bugfix for workspace_custom_startup_expr check & updated compat #172

Closed gnadt closed 1 year ago

gnadt commented 1 year ago

Before this bugfix, the "Expected the workspace_custom_startup_expr setting to not be set by someone else; overriding it." warning message always appeared when evaluating multiple Pluto notebooks due to a quote vs string inconsistency. Also updated compat & example.jl for the latest package releases.

rikhuijzer commented 1 year ago

Thank you for this nice PR

warning message always appeared when evaluating multiple Pluto notebooks due to a quote vs string inconsistency.

I was already wondering why I kept seeing that error. Thanks for figuring out the root cause (the bug was introduced in https://github.com/rikhuijzer/PlutoStaticHTML.jl/pull/171)!

I'll merge this once the tests pass and I'll release a new version soon. I think Pluto is gonna do a new release soon (https://github.com/fonsp/Pluto.jl/commit/cb21fa9beead6d55d74a2991d1bd8e8ce422b7e4), so I'll wait for that before tagging a new release here.

gnadt commented 1 year ago

No problem & sounds good, thank you!