rikimaru0345 / Ceras

Universal binary serializer for a wide variety of scenarios https://discord.gg/FGaCX4c
MIT License
484 stars 53 forks source link

Bug: ProtocolChecksum should not use ".FullName" #70

Open rikimaru0345 opened 5 years ago

rikimaru0345 commented 5 years ago

The ProtocolChecksum will not match if a project is compiled for different runtimes. It uses type.FullName, which includes the assembly Name/Version/... None of those things should be included.

Fix: just using .FriendlyName(true) or something like instead that should do the trick (along with a bunch of unit-tests!)

Not sure when I'll get around to fixing this, but I hope I can work on it tomorrow.