search

rikka0w0 / MobZReborn

Continued of https://github.com/Globox1997/MobZ
https://www.curseforge.com/minecraft/mc-mods/mobz
7 stars 1 forks source link

Mixin causing crash due to possible interference with FabricShieldLib. #35

Closed CringeStar closed 1 year ago

CringeStar commented 1 year ago

https://github.com/rikka0w0/MobZReborn/blob/3835fe46b28b39d48ffbceaa6bf364863b9f42e2/fabric/src/main/java/net/mobz/mixin/MetalShieldMixin.java#L11

This override I think is causing the issue 142 in FabricShieldLib.

Here is the crash log provided on our issue: https://pastebin.com/JpakGKAx

You can head over to our issue for more detail.

manu1978 commented 1 year ago

Works great with FabricShieldLib-1.6.0-1.19.jar version https://www.curseforge.com/minecraft/mc-mods/fabric-shield-lib/files/3970058

CringeStar commented 1 year ago

That version of the library is outdated, as we are now on 1.7. Also, the other cause of this problem is that your mixin is declared abstract which causes the crash:

java.lang.AbstractMethodError: Method net/mobz/item/Shield.getCoolDownTicks()I is abstract
    at net.mobz.item.Shield.getCoolDownTicks(Shield.java)
    at com.github.crimsondawn45.fabricshieldlib.initializers.FabricShieldLibClient.lambda$onInitializeClient$0(FabricShieldLibClient.java:73)
    at net.fabricmc.fabric.api.client.item.v1.ItemTooltipCallback.lambda$static$0(ItemTooltipCallback.java:37)
    at net.minecraft.class_1799.handler$gao000$fabric-item-api-v1$getTooltip(net/fabricmc/fabric/mixin/item/client/ItemStackMixin.java
CringeStar commented 1 year ago

Any updates on this?

Chris-Creates commented 1 year ago

also getting an error with this with shield lib.

CringeStar commented 1 year ago

Any updates?

Sunconure11 commented 1 year ago

I'm having the same issue. It started happening after pulling C2ME.

https://gist.github.com/Sunconure11/b3162a9d7b1fdd9e365d33ffc07e3898

@rikka0w0 @stellarwind22

CringeStar commented 1 year ago

The main source of this issue appears to be the mixin in this mod is declared abstract. @rikka0w0

Mathio95 commented 1 year ago

Having the same issue, any updates?

Titodelux commented 1 year ago

I am having the same issue u.u

Sunconure11 commented 1 year ago

Manu's advice works fine for me.

CringeStar commented 1 year ago

Manu's advice works fine for me.

It references an outdated version of the library, so it idnt a fix. Also, we are trying to update the library to our next version (1.7.1) and this bug has halted our development since we want to fix the issue in the update. @rikka0w0 Please update and fix your mod.

CringeStar commented 1 year ago

@rikka0w0 Please fix this, as we are trying to release the next library version and this is the last major bug left.

rikka0w0 commented 1 year ago

In FabricShieldLib 1.7, one method has been renamed: image

I will update the 1.19.2 MobZ to support FabricShieldLib 1.7.

CringeStar commented 1 year ago

that seemed to fix the crash, so thanks!