search

rikkimax / alphaPhobos

Assume License: Boost
11 stars 1 forks source link

uri: naming #3

Closed dhasenan closed 8 years ago

dhasenan commented 8 years ago

The uri module has many functions that begin with the string "URI". D naming convention states that the first character of a function should start with a lowercase character.

The module is called "uri" and defines a struct called "URIAddress" but seems to be dealing with URLs instead. Perhaps the module should be called "url" and define a struct called "URL".

dhasenan commented 8 years ago

Also, the names of various components should match standard names. For instance, URIProtocolPrefix should be called "scheme", since that's standard.

dhasenan commented 8 years ago

The accessor for the pre-split path component is called "parts". It's hard to imagine a more generic name.