search

rikmms / progress-bar-4-axios

Slim progress bar (NProgress) for Web applications that use Axios library for HTTP requests
MIT License
246 stars 32 forks source link

Make it work with a custom instance #6

Closed wuelcas closed 6 years ago

wuelcas commented 6 years ago

Solves #5

Now an axios custom instance can be pass to the function as a param. I put it as the second param to not affect current applications that are maybe using the nprogress config.

My suggestion is that the function should receive one single param which would be an object containing the custom instance and the nprogress config.

wuelcas commented 6 years ago

Also can you let me know when this is going to be live in npm? I'm currently working on an application using this package and it would be very helpful if this change (if it's merged) it's live to use it. Thanks.

rikmms commented 6 years ago

Hi @wuelcas

Thanks for the improvement. Good work! It will be available on NPM soon.

rikmms commented 6 years ago

New version [1.2.0] published on NPM ;-)