riksweeney / edgar

A 2D platform game with a persistent world. When Edgar's father fails to return home after venturing out one dark and stormy night, Edgar fears the worst: he has been captured by the evil sorcerer who lives in a fortress beyond the forbidden swamp.
https://www.parallelrealities.co.uk/games/edgar
115 stars 29 forks source link

Please install edgar.appdata.xml.in #1

Closed nemysis closed 8 years ago

nemysis commented 9 years ago

Hello I'm openSUSE and FreeBSD maintainer for The Legend of Edgar and more others Yours games :)

https://build.opensuse.org/package/show/home:nemysis:branches:games/edgar

https://www.freshports.org/games/legend-of-edgar/

I see in sources

icons/edgar.appdata.xml.in

but is not installed, please change makefile.

riksweeney commented 9 years ago

Just to confirm, this file should be installed to /usr/share/appdata/edgar.appdata.xml is that correct?

nemysis commented 9 years ago

Yes this is right

/usr/share/appdata/edgar.appdata.xml

And add also how is to update mime database.

Thanks.

riksweeney commented 9 years ago

Sorry, I don't understand what you mean regarding the mime database, do you want me to also run the update-mime-database command? Is this required for openSUSE and FreeBSD?

nemysis commented 9 years ago

Yes is important in openSUSE and FreeBSD I have think on this or similar

%post
update-mime-database %{_datadir}/mime

%postun
update-mime-database %{_datadir}/mime

This is similar than for Desktop entry file which i use for Edgar in openSUSE

%if 0%{?suse_version}
    %suse_update_desktop_file %{name}
    %fdupes -s %{buildroot}%{_prefix}
%endif
akien-mga commented 8 years ago

This is not a MIME type definition, so nothing is required regarding the MIME database. Even if it were, it's usually the packager's job to do this kind of thing, and should not be done in the upstream Makefile.