search

riksweeney / edgar

A 2D platform game with a persistent world. When Edgar's father fails to return home after venturing out one dark and stormy night, Edgar fears the worst: he has been captured by the evil sorcerer who lives in a fortress beyond the forbidden swamp.
https://www.parallelrealities.co.uk/games/edgar
116 stars 28 forks source link

cleanup code + fix typo #22

Closed bmwiedemann closed 7 years ago

bmwiedemann commented 7 years ago

one trivial cleanup commit and one typo fix

See commit messages for details.

bmwiedemann commented 7 years ago

btw. man page says scandir() is available since 4.3BSD, POSIX.1-2008 so if you want to support old/other systems, it would need to be solved differently

riksweeney commented 7 years ago

I'm not sure what this does? Is there a bug in the packing code?

polluks commented 7 years ago

It's ok, POSIX is the lowest common divisor. But Windows...

Sent from my Samsung SM-A520F using FastHub

polluks commented 7 years ago

@riksweeney not a bug, right now paks do not differ of the order of their files anymore.

Sent from my Samsung SM-A520F using FastHub

riksweeney commented 7 years ago

OK. I just tried the updated code and the Windows version now fails to compile.

polluks commented 7 years ago

@riksweeney https://groups.google.com/forum/m/#!topic/comp.os.ms-windows.programmer.win32/SO0pdXmRFHY

Sent from my Samsung SM-A520F using FastHub

bmwiedemann commented 7 years ago

I guess the alternative approach would be to leave this code as is and make it build+install+work with NO_PAK=1 which makes it more like normal Linux packages anyway.

riksweeney commented 7 years ago

That's a better idea.

bmwiedemann commented 7 years ago

re-using this PR for the code cleanup and typo fix and #23 for the makefile improvement