search

rikulo / bootjack

Twitter Bootstrap ported in Dart.
https://quire.io
Apache License 2.0
88 stars 15 forks source link

Changed _cnt to set content value using a NodeValidatorBuilder. #11

Closed nawafnaim closed 10 years ago

nawafnaim commented 10 years ago

Changed _cnt to set content value using a NodeValidatorBuilder to allow hyperlinks inside content. With current implementation, Dart sanitizes href attributes inside popover's content.

nawafnaim commented 10 years ago

Maybe a better way to approach this is to introduce an optional NodeValidatorBuilder parameter in the Base constructor to allow users to define their own allowed attributes. I see many use cases for this.

nawafnaim commented 10 years ago

I have introduced an optional NodeValidatorBuilder field to tooltip.dart and popover.dart so that users can insert their own html tags to popovers without Dart sanitizing them. I wish one of the admins review this pull request. Thank you.

tomyeh commented 10 years ago

From git diff, it marked every line as changed. It is hard to track what really happens. I think it is caused by CR/LF vs LF issue. I added .gitattributes to enforce the use of LF. Please redo the submit and pull request. Thanks.

nawafnaim commented 10 years ago

I've redid and resubmitted the pull request. Thanks.

tomyeh commented 10 years ago

Invalid