ramsestom
commented
4 years ago OK found the origin of the issue.
the socket.onack() method is using the Function.apply method. But when this method is passed a List , each element of this List is considered an argument of this function (https://api.dartlang.org/stable/2.6.1/dart-core/Function/apply.html). So if the object returned by the ack is a List=a json array (which was my case), the callback do not behave as expected
To fix this bug, line 323 of the socket.dart file needs to be changed to:
Function.apply(ack, [packet['data']]);
so that even if the result of the ack is a List, it would be treated as a unique single object to be passed as argument to the ack callback.
Bytheway, The emitBuffered function is bugged also. It should be:
emitBuffered() {
var i;
for (i = 0; i < this.receiveBuffer.length; i++) {
List args = this.receiveBuffer[i];
if (args.length > 2) {
Function.apply(super.emit, [args.first, args.sublist(1)]);
} else {
Function.apply(super.emit, args);
}
}
this.receiveBuffer = [];
for (i = 0; i < this.sendBuffer.length; i++) {
this.packet(this.sendBuffer[i]);
}
this.sendBuffer = [];
}Same fix should also probably be applied to other 'Function.apply' calls (I didn't inspect the whole lib code, only the socket.dart file so the same issue can potentially afect other functions in other files) where function argument type are not known (=are dynamic) and can potentially be a List
jumperchen
Zony-Zhao
I am trying to use this lib but it doesn't seem to work I tried with a really simple example like this:
but it is throwing an error. Here is the exception call stack:
and the Log from the lib is as follow:
Strange thing is that even if I call a simple emit function instead of emitWithAck, like this:
_socket.emit("authenticate", {"strategy":"local", "email":"test@yahoo.fr", "password":"test69"});no error is thrown by the app but the log still hang on after the "readyState opening" message and the rest of the log is only printed when the app is killed... So here is the log I have in this case:
any idea of what might be the issue and how to solve it?