search

rikulo / xml-crypto

Xml digital signature library for Dart
https://pub.dev/packages/xml_crypto
MIT License
4 stars 0 forks source link

Errors when handling files with CRLF #5

Closed scribetw closed 1 year ago

scribetw commented 1 year ago

Steps

  1. Clone v2.1.4
  2. Run dart test on Windows

Expect

No error

Actual

Some test case failed

Debug Information

By default, cloned files in Windows are in CRLF line feed. I found the result of C14n XML was not expected.

See: https://github.com/rikulo/xml-crypto/actions/runs/3917040048

Also, ninja_pem has a bug while handling CRLF PEM string => https://github.com/ninja-dart/pem/issues/1 And xml handles End-of-Line => https://github.com/renggli/dart-xml/issues/160

scribetw commented 1 year ago

All dependencies were updated or applied with the workaround.