search

rikvdkleij / intellij-haskell

IntelliJ plugin for Haskell
https://rikvdkleij.github.io/intellij-haskell/
Apache License 2.0
1.32k stars 94 forks source link

Merging Layoutlexer #646

Open ishmum123 opened 3 years ago

ishmum123 commented 3 years ago

@rikvdkleij I got the tests running (by replacing with the actual), the simplelayout and letin tests are still failing

ishmum123 commented 3 years ago

@rikvdkleij please suggest a change I would try do as much as I can

rikvdkleij commented 3 years ago

@ishmum123 Sorry, I also don't know how to continue exactly. We have to define a PSI tree which will parse all GHC code. I need some time to investigate this.

ishmum123 commented 3 years ago

Does this help in any way? https://gitlab.haskell.org/ghc/ghc/-/blob/master/compiler/GHC/Parser/Lexer.x

ishmum123 commented 3 years ago

Let me know if you want to pair program

ishmum123 commented 3 years ago

@rikvdkleij does this push give you any ideas about the solution?

ishmum123 commented 3 years ago

@rikvdkleij I could get the layout tests to pass after modifying the where_clause. For some reason cannot parse real files that I have tested with. Would you please take a look?

rikvdkleij commented 3 years ago

@ishmum123 do you mean that you can’t parse real files when the plugin is used?

Great that you still working on this issue!

ishmum123 commented 3 years ago

@rikvdkleij yes getting some problems on real files. Can you please check where it might have gone wrong?