search

rikyoz / bit7z

A C++ static library offering a clean and simple interface to the 7-zip shared libraries.
https://rikyoz.github.io/bit7z
Mozilla Public License 2.0
634 stars 116 forks source link

Collision of fs namespace #141

Closed ra-dave closed 1 year ago

ra-dave commented 1 year ago

I'm trying to utilize bit7z in our product code to evaluate it. I am only using bitarchivewriter.hpp currently. I am getting a namespace collision with the fs namespace as our code also is using that namespace. I'm not sure yet why it's colliding, isn't bit7z's usage of that namespace an internal thing?

rikyoz commented 1 year ago

Uhm strange!

isn't bit7z's usage of that namespace an internal thing?

Yes, it is, but unfortunately, there are some "semi-internal" classes that belong to the public API and need to use fs::path, hence that namespace had to be declared in a public header too.

I have some possible solutions to this, but I need to verify which might be the best.

Anyway, thanks for pointing out this issue!

rikyoz commented 1 year ago

Fixed in v4.0.0.