search

rikyoz / bit7z

A C++ static library offering a clean and simple interface to the 7-zip shared libraries.
https://rikyoz.github.io/bit7z
Mozilla Public License 2.0
634 stars 116 forks source link

[fix] fix-filesystem-include-error #147

Closed luciouskami closed 1 year ago

luciouskami commented 1 year ago

146

rikyoz commented 1 year ago

Hi! Thanks for the pull request!

Unfortunately, using a namespace alias doesn't fix the error caused by the namespace redefinition, at least in general; for example, on some compilers like GCC and Clang, it doesn't work (https://gcc.godbolt.org/z/6javMGjs7).

Anyway, I already fixed the https://github.com/rikyoz/bit7z/issues/141 bug issue two weeks ago on the develop branch (https://github.com/rikyoz/bit7z/commit/9baa3cd05e93d34e1eb66396ec34a11cf722e3c9). I decided to put the fs namespace inside the bit7z one, so there should be no conflict. I'll merge the fix to the master branch soon.

Anyway, thank you again!