BitArchiveInfo with encrypted archives

csabesz88 commented 4 years ago

Description

BitArchiveInfo did not work with encrypted archives since opening the file was done in the constructors, there was no way to define a password query function or pass the password down the constructor line.

Motivation and Context

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

rikyoz commented 4 years ago

Hi! First of all, thank you for you pull request! This feature is definitely a must-have that I totally forgot to implement in the last version of bit7z! In addition to your commit, I took the liberty of adding the support to header encrypted archives read from buffers or standard streams, as well as of fixing documentation and minor code style consistency issues. I will squash and merge the pull request into master and probably release it as a bugfix version 3.1.1, since it was an error to not have this functionality in the current stable release. Thank you again!

csabesz88 commented 4 years ago

Hey, thank you for the awesome lib :)

Cheers Csaba

rikyoz commented 4 years ago

You're welcome, I'm glad it's appreciated! :) Oz

rikyoz / bit7z