search

rikyoz / bit7z

A C++ static library offering a clean and simple interface to the 7-zip shared libraries.
https://rikyoz.github.io/bit7z
Mozilla Public License 2.0
623 stars 113 forks source link

FileCallback should report filename with path #46

Closed neolib closed 11 months ago

neolib commented 3 years ago

I am a new user of this library, hope I am not making fundamental misunderstanding of the lib.

I found that FileCallback only reports bare filename without path information in archive.

Can you make the callback report full path? Full path can be:

It's up to you to decide which is appropriate.

rikyoz commented 3 years ago

Hi, and thank you for using bit7z!

Can you make the callback report full path? Full path can be:

  • Full path of the extracted file on disk
  • Relative path as it appears in archive file

It's up to you to decide which is appropriate.

I think it's an excellent idea! Probably I'll make it report the relative path in the archive. I was already thinking of changing the FileCallback to provide more information about the current file being processed (e.g., its size). I'll evaluate what to do and implement it for the next major release (v4.0).

I'm currently working on a significant refactoring of the library's internal code, which I don't know how long it will take me (I'm working on it in the spare time). So I don't have a precise deadline, but I hope to release it as soon as possible. Thank you again!

rikyoz commented 11 months ago

Implemented in v4.0.0.