search

rikyoz / bit7z

A C++ static library offering a clean and simple interface to the 7-zip shared libraries.
https://rikyoz.github.io/bit7z
Mozilla Public License 2.0
623 stars 113 forks source link

[Bug]: inconsistency in the file Build.txt in v3.1.4 #56

Closed fabri9532 closed 2 years ago

fabri9532 commented 2 years ago

bit7z version

3.1.x

7-zip version

v19.00

7-zip DLL used

7z.dll

MSVC version

2017

Architecture

x86_64

Which version of Windows are you using?

Windows 10

Bug description

Is not a real bug.

In the 7z files released of v3.1.4 the "Build.txt" file reports the v3.1.3. Is the released library the v3.1.4?

Thanks in advance, Fabrizio.

Steps to reproduce

No response

Expected behavior

No response

Relevant compilation output

No response

Code of Conduct

rikyoz commented 2 years ago

Hi!

Is not a real bug.

In the 7z files released of v3.1.4 the "Build.txt" file reports the v3.1.3. Is the released library the v3.1.4?

Yes, it is the v3.1.4! Before pushing the new release tag, I forgot to change the version specified in the CI/CD configuration file, which is the value written in the "Build.txt" file. But the library version built is the correct one. I fixed the configuration file just after the release (https://github.com/rikyoz/bit7z/commit/c2db868e70aac4f28c4e792f552968260c141bc8), but I didn't update the released archives. To avoid confusion, I'll probably need to update them, though. And I'll probably change the AppVeyor configuration to use the tag value as the version in the "Build.txt" file, so I'll not need to change it every time. Anyway, thanks for pointing it out!

fabri9532 commented 2 years ago

Thank you for the clarification.

Fabrizio

rikyoz commented 2 years ago

I updated the released archives.

Thank you for the clarification.

You're welcome!