Open ajmacd opened 1 year ago
SonarCloud Quality Gate failed.
0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells
No Coverage information
0.0% Duplication
Catch issues before they fail your Quality Gate with our IDE extension SonarLint
@RyoshiKayo interested in your perspective here if you get a chance to take a look, as the (apparently) breaking changes were due to the improvements you made earlier this year. Curious to know why you weren't hitting the issue.
The lambdas were erroring with:
AFAICT, the handler function needs to be a named, and not default, export.
Furthermore, it appeared that, in some cases at least, the startstop lambda could exit before the network request to the ECSClient completed. This also now awaits the response before exiting the lambda.
Finally, this causes the status lambda to always return some value.