Fix `aga_product` in `test_cases` and more

rileyshahar / aga

aga grades assignments

MIT License

8 stars 2 forks source link

Fix `aga_product` in `test_cases` and more #50

Closed FlickerSoul closed 2 years ago

FlickerSoul commented 2 years ago

Fix aga_product in test_cases
support singleton input for aga_* kwargs, like aga_hidden=True
add more tests

FlickerSoul commented 2 years ago

sorry about the messy naming scheme. I'll refactor it a bit later :)

FlickerSoul commented 2 years ago

and probably making things too complicated than it should be. removing some of the support like you said can be a better idea :)

rileyshahar commented 2 years ago

To be honest, I think overload is not the right solution. I think we can just break backwards compatibility; there's really no reason to support giving iterators as options to test_cases. Thoughts?

rileyshahar commented 2 years ago

Also a few linter errors - I don't really care about the line break before binary operator, you can disable that in .flake8 if you want (add "W503" to ignore) since it's being deprecated anyway, but if you can fix the line length error it'd be awesome.

Thanks!

FlickerSoul commented 2 years ago

I'll fix the linter errors :)