rileytestut / AltServer-Windows

GNU Affero General Public License v3.0
141 stars 49 forks source link

Need MFC libraries #22

Open JJTech0130 opened 2 years ago

JJTech0130 commented 2 years ago

Just an addition to the build instructions, mdnsresponder requires the MFC component in Visual Studio, which isn't always included. The build fails with cryptic errors otherwise.

JJTech0130 commented 2 years ago

Also Clang? Should hold off reporting issues till I get all the way through so I can get them all

JJTech0130 commented 2 years ago

Also is it really necessary to compile winsparkle? It appears that there is a dll already in the libraries folder...

JJTech0130 commented 2 years ago

Also I'm having to use vcpkg to install openssl, not sure if that's the correct way

JJTech0130 commented 2 years ago
And now I'm getting this error... Severity Code Description Project File Line Suppression State
Error C2039 codecvt_utf8: is not a member of std AltServer C:\Users\JJTech\source\repos\AltServer-Windows\AltServer\ClientConnection.cpp 27

EDIT: Searching the internet, I'm seeing people had deprecation warnings for codecvt_utf8... I wonder if I'm using a newer version where it was finally removed... EDIT: Just needed to add this to ClientConnection.cpp, as stated in the README 🤦‍♂️:

#include <codecvt>
JJTech0130 commented 2 years ago
Now trying to compile ldid.lib for it... Getting this error: Severity Code Description Project File Line Suppression State
Error could not open 'C:\Users\JJTech\vcpkg\installed\x86-windows\lib*.lib': invalid argument ldid C:\Users\JJTech\source\repos\AltServer-Windows\ldid\lld-link 1

EDIT: Only way I could find to fix this is to temporarily modify vcpkg to disable autolinking per https://github.com/microsoft/vcpkg/issues/4359, except removing the condition entirely

JJTech0130 commented 2 years ago

I build it successfully in a VM! now to get it to build in appveyor

kylefmohr commented 2 years ago

Can confirm that MFC is needed to build mDNSresponder, specifically, one needs to re-run the Visual Studio 2019 installer, go to the "Individual components" tab, check the box for "C++ MFC for latest v142 build tools (x86 & 64)" and click "Modify"

Thanks for the tip @JJTech0130