rilldata / rill

Rill is a tool for effortlessly transforming data sets into powerful, opinionated dashboards using SQL. BI-as-code.
https://www.rilldata.com
Apache License 2.0
1.73k stars 117 forks source link

[stub] implement a virtual list component for the column profiles #317

Closed hamilton closed 5 months ago

hamilton commented 2 years ago

Rill Developer does not scale well in the column-space; even if you have so many rows, the application's performance drags down when viewing & editing a model with many columns. There are a number of solutions to this problem, but usually virtualization is the solution most UI engineers implement.

We're already using Tanstack Virtual for our tables. It makes sense to implement virtualization for the column profiles as well, which will likely speed up the overall navigation and editing interactions.

A few other experiments:

bcolloran commented 2 years ago

I believe this issue is now either complete or made obsolete by @djbarnwal 's work on the speeding up the profiles and updating the priority queue? @djbarnwal, could you please confirm that this issue is no longer needed, and if that is the case please close? Thank you!

djbarnwal commented 2 years ago

Hey @bcolloran Virtualization of Column Profile is something we still want to do. As of now if we have say 500 column profiles, the UI would freeze. Virtualization would helps us prioritize the column profiles which are above the fold. Me and @hamilton have discussed this issue and I would be picking this up at some point.

hamilton commented 1 year ago

I'm updating the OP now to reflect where we are today.