search

rilldata / rill

Rill is a tool for effortlessly transforming data sets into powerful, opinionated dashboards using SQL. BI-as-code.
https://www.rilldata.com
Apache License 2.0
1.72k stars 117 forks source link

Fix(explore): Misaligned column layout for Measures without time series data #4258

Open briangregoryholmes opened 8 months ago

briangregoryholmes commented 8 months ago

On shorter browser windows, the layout of Measures in dashboards without time series data seems unintentional.

@jkhwu Do we have mocks for this state? There's a lot of manual calculation going in the component responsible for this, but I'm not sure where the justification came from.

Screenshot 2024-03-06 at 12 38 27 PM
djbarnwal commented 8 months ago

Yeah, this hasn't been touched in a long time and has many regressions. We should re-do how we organize them. Previously the idea was to split them into n x m grid such that you don't have to scroll too much to see all the measures while also maintaining enough space for the leaderboards. Also we were trying to align the measure titles together i.e. if in a row we have 3 measures and one of them takes 2 lines for the title, we were trying to align all other titles in that row together. I feel for now maybe we can just use native css grid without worrying about precise alignment.

jkhwu commented 8 months ago

I don't currently have mocks for this state. If it's easier to maintain I would be ok with just doing a single column, left-aligned, of the bignum tiles. This might lay good groundwork for our upcoming 3-column layout concept.