search

rilldata / rill

Rill is a tool for effortlessly transforming data sets into powerful, opinionated dashboards using SQL. BI-as-code.
https://www.rilldata.com
Apache License 2.0
1.73k stars 117 forks source link

fix: bookmark query by doing a case insensitive query #6093

Closed AdityaHegde closed 2 days ago

AdityaHegde commented 6 days ago

Our top navigation bar uses lower case resource name so if a bookmark was created with original case and navigated to using top bar the older bookmarks were not found anymore.

Making the bookmark query case insensitive since resource name is already case insensitive in our system.

AdityaHegde commented 3 days ago

Updated bookmarks_search_idx. Do you mean other indices or other columns in this index?

For other columns it doesnt make sense, the only one we could possibly do it is resource_kind but since we use constants for that it would be overkill.

For other indices, for sure. Lets take as a follow up of this PR since it would need some thorough check.