search

rilldata / rill

Rill is a tool for effortlessly transforming data sets into powerful, opinionated dashboards using SQL. BI-as-code.
https://www.rilldata.com
Apache License 2.0
1.73k stars 117 forks source link

Support infinite query when listing org users and invites #6128

Closed lovincyrus closed 7 hours ago

lovincyrus commented 12 hours ago

closes https://github.com/rilldata/rill/issues/6113

https://github.com/user-attachments/assets/95d880a2-e84b-400c-bce7-9c1d21e63916

ericokuma commented 9 hours ago

Looks good!

ericokuma commented 8 hours ago

Ah, if I resize the browser window, then the page scrolls.

Same with the second item you raised @ericpgreen2.

I don't see the page scroll when the browser window is at full height

lovincyrus commented 7 hours ago

UXQA:

  1. When the users table is short, the page scrolls unnecessarily (Jam)
  2. Related, when the users table is long, I'm seeing two scroll bars: one at the page-level, one at the table-level. (Jam)

What if we remove the table's min-height and just use a max-height, small enough so that it doesn't trigger a page-level scroll?

Min height is the culprit, tracing this..

lovincyrus commented 7 hours ago

Latest demo:

https://github.com/user-attachments/assets/f89dda12-19e9-4835-bdb0-3ed1f20e555b