search

rillig / gobco

Measure branch coverage of golang tests
62 stars 12 forks source link

get c1 coverage report #29

Closed visu-suganya closed 11 months ago

visu-suganya commented 11 months ago

As discussed in issue, fix for c1 coverage has been added

visu-suganya commented 11 months ago

@rillig Please check

rillig commented 11 months ago

In parallel, I implemented the feature myself, see https://github.com/rillig/gobco/tree/branch-coverage. I originally only planned to do a thorough review of your changes, but for that, I had to move the tests around like you did, to see the actual changes to the file content, such as changed comments. While doing that, I noticed that it would be beneficial to not duplicate the tests, and when I continued on that path, I suddenly had the feature working.

visu-suganya commented 11 months ago

@rillig Im happy that I tried to implement this even though Im not expert in go. Thanks for the new implementation and it is very helpful for my need.