search

rime / librime-charcode

4 stars 3 forks source link

chore: remove unused includes #2

Closed iovxw closed 2 years ago

iovxw commented 3 years ago

This helps Trime https://github.com/osfans/trime/blob/8232e9802b/app/src/main/jni/cmake/RimePlugins.cmake#L40-L44

lotem commented 2 years ago

Thanks. Merged.

lotem commented 2 years ago

Reverted. The include is needed for Windows build.

References: https://stackoverflow.com/a/3475677 https://docs.microsoft.com/en-us/windows/win32/api/winsock/nf-winsock-ntohs

Error log at https://github.com/rime/librime/runs/5065227018?check_suite_focus=true#step:9:87

D:\a\librime\librime\plugins\charcode\src\codepoint_translator.cc(67,13): error C3861: 'ntohs': identifier not found [D:\a\librime\librime\build\plugins\charcode\rime-charcode-objs.vcxproj]
D:\a\librime\librime\plugins\charcode\src\codepoint_translator.cc(85,19): error C3861: 'ntohl': identifier not found [D:\a\librime\librime\build\plugins\charcode\rime-charcode-objs.vcxproj]