search

rime / librime

Rime Input Method Engine, the core library
https://rime.im
BSD 3-Clause "New" or "Revised" License
3.36k stars 550 forks source link

move some headers #892

Closed eagleoflqj closed 3 months ago

eagleoflqj commented 3 months ago

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

rime_api_impl.h uses definitions like RIME_DEPRECATED defined in rime_api.h. However, it doesn't include rime_api.h, so when opening this file editor complains. After including rime_api.h in rime_api_impl.h, wherever rime_api_impl.h is included, there is no need to include rime_api.h, so they are removed.

Unit test

Manual test

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info