search

rime / librime

Rime Input Method Engine, the core library
https://rime.im
BSD 3-Clause "New" or "Revised" License
3.36k stars 550 forks source link

Replace LevelDB with RocksDB #934

Closed WhiredPlanck closed 3 weeks ago

WhiredPlanck commented 1 month ago

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes # N/A

Feature

Describe feature of pull request

RocksDB is a more active fork of LevelDB with a batch of improvements, developed by Meta (Facebook).

Unit test

Manual test

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

WhiredPlanck commented 3 weeks ago

It seems that rocksdb is not a good choice. Close this PR.