rimerosolutions / ant-git-tasks

Ant tasks for Git with JGit
Apache License 2.0
41 stars 39 forks source link

Push rejection detection using RemoteRefUpdate status #17

Closed mirvnillith closed 9 years ago

mirvnillith commented 9 years ago

The main point of this PR is GitTaskUtils.validateRemoteRefUpdates, but there are also some formatting (I've tried to align with you, but I guess some of my earlier sins were merged into your codebase). I also fixed newlines (I'm on Windows) so the diffs should work better (although GitTasks and TagTask don't)!

mirvnillith commented 9 years ago

As a novice in git I did not work out how to branch off of an old commit (I wanted to keep this separate, but then I should've branched before the other stuff here), so one more feature went into this PR: the ability to delete a remote branch using push.

yveszoundi commented 9 years ago

That's fine for the git workflow and commands, as long as you realize what could've been done better and keep learning/improving, it's all good :-). In the Open Source world, I try to keep workflow simple, avoid anarchy but allow people to contribute easily.

Thanks, would you like to be added as a collaborator, as you're actively contributing to this project?

Yves

mirvnillith commented 9 years ago

Thank you for understandin and I agree, it's a versioning system so you can always go back!

mirvnillith commented 9 years ago

Oh, and I'd be proud to be named a collaborator as this lib really saved us a lot of work (we came from SVN, had everything automated just so and kind of rushed the git migration quite close to a major release).