rimorob / netres

To support an ICML submission - anonymous for now
1 stars 1 forks source link

Fix the assess() function #3

Open rimorob opened 1 year ago

rimorob commented 1 year ago

Plot AUCs and PR-AUCs not as dots but on the same AUC plot with error bars, using either/both of ROCR and PROC

fkgruber commented 1 year ago

we want:

fkgruber commented 1 year ago

Hi Boris @rimorob I have a first version of the assess plotting. It plots what you have now which is auc vs iteration and also saves the roc curves at each iteration as:

image

One question I have is regarding the p-value. THe ROCR test function allows to compare 2 roc curves. Were you thinking to compare the ROC of the true vs each iteration or each iteration with estimated latent variable vs the roc curve if the 1st iteration (ignoring latent variables)?

rimorob commented 1 year ago

Yes, I think AUC vs the true network (minus the edges crossing into the latent space) would be used as the basis for comparison

Looks nice!

rimorob commented 1 year ago

Fred, is this fully finished?

fkgruber commented 1 year ago

I think I'm missing the p-value

fkgruber commented 1 year ago

Yes, I think AUC vs the true network (minus the edges crossing into the latent space) would be used as the basis for comparison

Looks nice!

Actually roc.test works by providing 2 roc objects which mean we need 2 estimated network vs the true. one option comparing the network from having the true latent variable in vs the last estimated network. Perhaps we should learn this oracle network by default to use as reference at the end

fkgruber commented 1 year ago

I will let assess have an argument with the oracle performance so we can show pvalues