rimusz / charts

Helm Charts for Kubernetes
MIT License
90 stars 70 forks source link

[gcloud-sqlproxy] Adding extraArgs without a value #115

Closed bluemalkin closed 2 years ago

bluemalkin commented 2 years ago

FEATURE REQUEST: Ability to pass extraArgs without a value

Version of Helm and Kubernetes: K8s: 1.20 Helm: 3.7.1

Which chart: gcloud-sqlproxy

What happened: -enable_iam_login extraArgs does not have a value: https://github.com/GoogleCloudPlatform/cloudsql-proxy#-enable_iam_login Thus the chart needs to accomodate extra_args without a value and with a single dash prefix.

kipit commented 2 years ago

Others flags are also booleans, for example: -structured_logs and -use_http_health_check.

The good news is that Cloud SQL Proxy use the standard Go flag package to parse command line options. This package parse boolean flags according these rules:

So, because @rimusz uses the key=value form, we are safe and this configuration should make your day:

extraArgs:
  enable_iam_login: "true"