Closed returnchung closed 1 year ago
Just added some fixes, welcome to test.
Thanks for supporting package and project settings and isort options, that's really amazing. I've tested and found some bugs, and create a Pull Request for you. Please take a look and let me know if any concerns.
I already done some fixes, so closed your pr.
There's still an issue on extending commands from list. The itertools.product is a generator of (option, value) tuple, so you need also to flat them. https://github.com/rimvaliulin/isorted/blob/e90dcffddb3348365a557079e2c806b67eca61c3/isorted.py#L140
@returnchung @rimvaliulin It would be much better to manually add custom.isort.cfg
file for each project and add it to .gitignore
instead of commiting unnecessary changes. Thanks to this new changes isorted
stopped working with standard .isort.cfg
config
@inmate37 Yeah, it's doable to add .gitignore
, however, there's still a situation that repository owner and contributors don't want include the irrelevant files in .gitignore
either. Keep the plugin flexible and configurable is still a good thing and users can choose the prefer way in using plugin.
And about new changes broken the isorted
, I think @rimvaliulin has fixed in 1.0.6
, please upgrade and try it again.
The most features in this Issue are covered in current version, so I'll close this. Thanks to @rimvaliulin again:)
Considering different
isort
configs are used in different projects, if we can also configure in the specific sublime project settings instead in the.isort.cfg
orpyproject.toml
, it's helpful, especially when you contribute to different projects but without isort config files.Besides, the
isort
has many options to sort, so we should also support to configure options in the package and project settings for common use and let it extendable for more flexible usage in the future. To do so, we can define some settings - options commands mapping and append to theisort_command
to run in subprocess once user specified. For instance: