rinchinov / ij-dbt-plugin

intelllij Idea plugin for DBT
https://plugins.jetbrains.com/plugin/23789-dbt
GNU General Public License v3.0
12 stars 1 forks source link

Project Settings files/paths are ambiguous/confusing #51

Open joshuataylor opened 3 months ago

joshuataylor commented 3 months ago

Recap of Settings

SCR-20240415-meer-2

Project path: file (dbt_project.yml) DBT profile path: directory (dbt profile) DBT interpreter path: file

Suggestion around Naming Convention

IMHO, the current naming isn't very clear if it's a directory or a file.

  1. Change Project path to be dbt_project.yml File Path, or just make it a directory? It should default to the current project, I don't believe PyCharm supports modules, etc.
  2. Change DBT profile path to dbt Profile Directory, add link to profiles.yml docs.
  3. Change DBT interpreter path logic, usually this is inside a virtualenv anyway, right? Do people use tools such as brew, chocately etc for dbt?

IMHO, this should either be the current Python Interprator virtualenv (if enabled), or the one on path (I think that's how it works right now(?)).

Validate Projct Settings

Maybe having a tickbox/cross next to each text input would be easier to see which setting is wrong?

richardguinness commented 3 months ago

Completely agree!

For me, I think I must set DBT profile path to ~/.dbt. But I still get an error "Error loading YAML file" which does reference the correct path to dbt_project.yml. This may be related to the issue your PR #50 attempts to address?

rinchinov commented 3 months ago

Hi, thanks for a raising this issue, I agree that configuration names could be confusing, it should be changed

joshuataylor commented 2 months ago

Apologies for the delay, i'll have more time next week to add to this - I'll create a PR to iterate feedback on :)