search

ring-clojure / ring-codec

Utility library for encoding and decoding data
MIT License
63 stars 30 forks source link

Add type hints for encode/decode #24

Closed yogthos closed 5 years ago

yogthos commented 5 years ago

GraalVM needs type hints to resolve encode and decode methods for URLEncoder and URLDecoder classes.

weavejester commented 5 years ago

Thanks for the PR. Can you format the commit message according to these rules and remove the backticks in the commit message body.

yogthos commented 5 years ago

Sure thing, let me know if it looks good.

weavejester commented 5 years ago

It looks like you forgot to remove the backticks, and the wrapping on the body isn't 72 characters.

Can you change the commit message to:

Add type hints for encode/decode

GraalVM requires type hints to disambiguate URLEncoder/encode and
URLDecoder/decode method invocations.

I don't think the second sentence is necessary, so we can omit it.

yogthos commented 5 years ago

updated, but it's gonna have to wrap at 66 unless you want to break URLEncoder/encode

weavejester commented 5 years ago

That's fine. Thanks for the patch.

yogthos commented 5 years ago

👍