search

ring-clojure / ring-codec

Utility library for encoding and decoding data
MIT License
63 stars 30 forks source link

[#26] Replace commons-codec with java.util.Base64 #27

Closed borkdude closed 3 years ago

borkdude commented 3 years ago

As discussed in #26, this PR replaces commons-codec with java.util.Base64.

weavejester commented 3 years ago

Thanks! Could you change "Get rid of" to "Remove" in the commit message? It makes it a little more searchable.

borkdude commented 3 years ago

@weavejester Do you want me to force-push to my branch or are you going to squash the commits? (Github can do this for you, if you choose squash instead of merge).

weavejester commented 3 years ago

Yes, please force-push to the branch. The GitHub "squash" option unfortunately doesn't preserve the merge commit, making it useless for my purposes.

borkdude commented 3 years ago

Done.