ring.util.codec/FormEncodeable impl for nil

[tomoharu-fujita]

form-encode fails to encode if nil value is in map:

user=> (require '[ring.util.codec :as codec]) user=> (codec/form-encode (codec/form-decode "a&b=1")) IllegalArgumentException No implementation of method: :form-encode* of protocol: #'ring.util.codec/FormEncodeable found for class: nil clojure.core/-cache-protocol-fn (core_deftype.clj:541)

It would be nicer if nil value treated as is.

user=> (extend-type nil

_=> codec/FormEncodeable

=> (form-encode* [ _] ""))

nil user=> (codec/form-encode (codec/form-decode "a&b=1")) "b=1&a="

[mping]

Any news on this?

[weavejester]

Since Object is encoded, it seems reasonable to encode nil as a blank string.

However, I'm not sure that a&b=1 should be decoded as {:a nil :b "1"}. It should probably raise an error instead.

[weavejester]

@buob: The exception is likely is likely caused by (:id user) or (:auth-token user) being nil.

[weavejester]

Fixed by #18