search

ring-clojure / ring-defaults

A library to provide sensible Ring middleware defaults
MIT License
343 stars 32 forks source link

Change default for `:absolute-redirects` to `false` #39

Closed jumarko closed 2 years ago

jumarko commented 2 years ago

As I mentioned on slack I'd love to see if absolute redirects were not enabled by default.

The original HTTP spec that mandated this has been replaced by a newer version about 8 years ago. This is causing problems for people running web apps behind load balancers and proxies terminating TLS. See https://github.com/clj-commons/friend/issues/4 and https://github.com/clj-commons/friend/pull/5

jumarko commented 2 years ago

@weavejester any thoughts on this?

weavejester commented 2 years ago

Apologies for the delay. I've been a little swamped recently. I think this is fine, and I'd welcome a PR.

jumarko commented 2 years ago

Here's the PR: https://github.com/ring-clojure/ring-defaults/pull/40 Thanks!