search

ring-clojure / ring-json

Ring middleware for handling JSON
313 stars 47 forks source link

Added support to handle malformed JSON #27

Closed dyba closed 10 years ago

dyba commented 10 years ago
dyba commented 10 years ago

I'd like to know if my try / catch is too wide. I noticed that was a concern with a previous pull request.

weavejester commented 10 years ago

The code in this PR doesn't actually work... Since this functionality seems to be something a lot of people are interested in, I'll see about working on something tonight.

dyba commented 10 years ago

Ugh, it was late at night and I rebased against master using Vim as the editor rather than Emacs. A few parentheses fell casualty as a result. I'll close this one PR and open a new one to trigger the build.

weavejester commented 10 years ago

You don't need to open a new PR. You just need to change the branch the PR points to.

Your code also has more problems than just missing parentheses. I'll talk about them in the new PR you opened, even though it's identical to this one.