weavejester
commented
9 years ago Aleph should still contain a :content-type key, as it's only deprecated in the spec, not removed entirely. So in this case, Aleph is at fault.
However, it is a good idea to switch from the deprecated :content-type key to the header key directly. To do this, you just need to change:
(:content-type request)To:
(get-in request [:headers "content-type"])You don't need to check multiple sources, because we have a spec telling us what the correct source is. You also don't need to add a new test; just change the existing tests to use the header. That should work with older and newer versions of Ring.
Finally, make sure that your commit summary line is brief, under 70 characters at maximum, otherwise you'll find it wrapping. So something more like:
Replace :content-type key with header lookup
Since Ring 1.3.0, the :content-type key has been deprecated.This provides a summary of the change, and a more detailed explanation of why in the commit body.
vignessh
The private function json-request? was checking for the presence of the :content-type keyword inside the request object. When I was running Compojure with Aleph, this was no longer true. request now contains a map :headers under which :content-type is available. Because of this, the ring-json middleware wasn't able to parse the incoming content as a json and instead left the body as a input stream.