Closed gregoriokusowski closed 8 years ago
👏🏼
Thanks for the fix. Could you amend your commit message to be in line with the repository? i.e. imperative mood for the summary with no ending period. So something like:
Fix parentheses in xml tests
I think you can also leave off the detailed explanation, since the problem and solution are obvious from the diff. :)
There we go!
Thanks! Merged.
The xml tests were able to pass even with wrong strings because
is
was receiving two string parameters instead of a single check. The second parameter is a message, so it was calling:(is form msg)
instead of(is form)