ring-clojure / ring-json

Ring middleware for handling JSON
313 stars 47 forks source link

Fix xml tests #39

Closed gregoriokusowski closed 8 years ago

gregoriokusowski commented 8 years ago

The xml tests were able to pass even with wrong strings because is was receiving two string parameters instead of a single check. The second parameter is a message, so it was calling: (is form msg) instead of (is form)

marceloboeira commented 8 years ago

👏🏼

weavejester commented 8 years ago

Thanks for the fix. Could you amend your commit message to be in line with the repository? i.e. imperative mood for the summary with no ending period. So something like:

Fix parentheses in xml tests

I think you can also leave off the detailed explanation, since the problem and solution are obvious from the diff. :)

gregoriokusowski commented 8 years ago

There we go!

weavejester commented 8 years ago

Thanks! Merged.