Enable JSON parsing when headers have been coerced to keywords

ring-clojure / ring-json

Ring middleware for handling JSON

313 stars 47 forks source link

Enable JSON parsing when headers have been coerced to keywords #69

Closed nnichols closed 3 years ago

nnichols commented 3 years ago

I've put wrap-json-body after middleware that coerces my headers into keywords more than a few times, and I've always struggled to remember that while debugging.

atomist[bot] commented 3 years ago

Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:

The commit message subject is over 50 characters.

weavejester commented 3 years ago

The Ring spec dictates that header keys are strings, so a request where header keys are keywords is incompatible. I don't want to add support for incompatible request maps; the whole point of a specification is to narrow options to make it easier for libraries to interoperate.