search

ring-clojure / ring

Clojure HTTP server abstraction
MIT License
3.77k stars 520 forks source link

Fix multipart params reflection warning #333

Closed RokLenarcic closed 6 years ago

RokLenarcic commented 6 years ago

This PR addresses a reflection warning in multipart-params code.

weavejester commented 6 years ago

Thanks for the patch. Can you fix the indentation?

RokLenarcic commented 6 years ago

I think it's fixed now.

weavejester commented 6 years ago

The indentation is still incorrect. It needs to be the same level of indentation as before the patch was applied. So for example, html5-encoding needs to be level with forced-encoding

RokLenarcic commented 6 years ago

Hm, that's how my IDE formatted it. But why not just have it all in one line? Comes in at 113 characters.

weavejester commented 6 years ago

Ring follows the Clojure Style Guide, which suggests that lines be no more than 80 characters. This also fits with my own preference, as a line not much longer than that goes off screen in my editor.