Closed danielcompton closed 5 years ago
Great work, It would be nice to be able to compile to native binaries microservices with GraalVM. The native compilation offers a major step up in startup times. Looking forward to this PR to get merged. 👏
That's interesting; I've never seen a type hint like that before. Can you remove the "Because" and "-" from the commit message? i.e.
Add type hint for server-connector
When building a Graal native image, Graal isn't able to resolve which
method to call. Adding the varargs type hint fixes this.
Once that's done I'll merge it in. I should be able to cut a release soon, I'm just waiting on one more commit.
Thanks, done. There's reference to this kind of hint at https://groups.google.com/d/msg/clojure/TFLUw8GSAbY/xgTR74fr8IgJ
Because:
Without this patch, the native image will build, but fail with:
cc: @BrunoBonacci, with this patch I was able to run https://github.com/BrunoBonacci/graalvm-clojure/tree/master/ring-jetty.