search

ring-clojure / ring

Clojure HTTP server abstraction
MIT License
3.77k stars 520 forks source link

[stacktrace.clj] Allow condensed stack trace format #386

Open sirmspencer opened 4 years ago

sirmspencer commented 4 years ago

https://clojure.atlassian.net/browse/CLJ-2463

The linked patch to clojure condenses the stack trace to the important line(s). It would be great to see something similar for ring.

Important lines would be the cause and the lines for files in the current app (handler.clj:116 my-app.handler/a-function)

To me this is the most important for the sterr logging. When the error is displayed in the browser, it seems fine to show the whole trace. In the browser it looks like there is some attempt to style less important line with a lighter font. This could be a little easier to read if the same important line(s) were highlighted.

sirmspencer commented 4 years ago

I see that errors are also returned with a :trimmed-elems that is the shorter trace. This is a good key to use instead of trying to filter elems based on file or something else.

sirmspencer commented 4 years ago

I have a solution working on my local project, Ill create a PR soon.