search

ring-clojure / ring

Clojure HTTP server abstraction
MIT License
3.77k stars 520 forks source link

Add type hint for proxy-handler #401

Closed matejvasek closed 4 years ago

matejvasek commented 4 years ago

Fixes possible issues with GraalVM native-image.

weavejester commented 4 years ago

Thanks for the patch. I think it might be better to put the type hint on the argument list, and you're also going to need to change the commit message to adhere to the contributing guidelines before it can be merged.

matejvasek commented 4 years ago

@weavejester done.

matejvasek commented 4 years ago

I think this fixes #396.

weavejester commented 4 years ago

Thanks. You have a small typo - "wiht" instead of "with" - and "graalvm" is generally capitalised as "GraalVM". The "Signed-off-by" field is also unncessary in this case, as it's the same as the commit author, and Ring doesn't use a DCO.

matejvasek commented 4 years ago

@weavejester this is weird, I just changed commit message and a test return non-zero code, but there are no failed tests.

weavejester commented 4 years ago

@weavejester this is weird, I just changed commit message and a test return non-zero code, but there are no failed tests.

It's just an issue with the CI server not being able to download a dependency from the maven server. I've restarted the CI build.