search

ring-clojure / ring

Clojure HTTP server abstraction
MIT License
3.75k stars 519 forks source link

Support passing a ssl context to run-jetty #412

Closed mcorbin closed 4 years ago

mcorbin commented 4 years ago

This commit adds a new option named :ssl-context to configure certificates using a Java SSLContext instead of a keystore file. It allows users to easily configure jetty with SSL from certs files, by using the less-awful-ssl library to create the SSLContext for example (as shown in the tests).

weavejester commented 4 years ago

Thanks for the PR. Please ensure it adheres to the contributing guidelines.

mcorbin commented 4 years ago

Thanks for the PR. Please ensure it adheres to the contributing guidelines.

I updated the commit.

weavejester commented 4 years ago

Can you change the commit message to:

Add option for passing an SSLContext to Jetty

Adds a new option named :ssl-context to configure certificates using a
SSLContext instance instead of a keystore file. This allows interop with
libraries like less-awful-ssl.
mcorbin commented 4 years ago

Can you change the commit message to:

Thanks you, I've updated the commit message.